summaryrefslogtreecommitdiff
path: root/common/cli_readline.c
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2023-03-28 08:34:13 +1300
committerTom Rini <trini@konsulko.com>2023-03-28 09:25:51 -0400
commit17b45e684af98c1cf37648ad05a98d500b367c5a (patch)
tree2453033d5e2077a2541844b4781e4d24623db11a /common/cli_readline.c
parent41a88ad529b3943b1e465846eb24fe2c29203e35 (diff)
cli: Correct several bugs in cli_getch()
This function does not behave as expected when unknown escape sequences are sent to it: - it fails to store (and thus echo) the last character of the invalid sequence - it fails to set esc_len to 0 when it finishes emitting the invalid sequence, meaning that the following character will appear to be part of a new escape sequence - it processes the first character of the rejected sequence as a valid character, just starting the sequence all over again The last two bugs conspire to produce an "impossible condition #876" message which is the main symptom of this behaviour. Fix these bugs and add a test to verify the behaviour. Signed-off-by: Simon Glass <sjg@chromium.org> Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Diffstat (limited to 'common/cli_readline.c')
0 files changed, 0 insertions, 0 deletions