summaryrefslogtreecommitdiff
path: root/drivers/clk/microchip/mpfs_clk_periph.c
diff options
context:
space:
mode:
authorConor Dooley <conor.dooley@microchip.com>2022-10-25 08:58:45 +0100
committerLeo Yu-Chi Liang <ycliang@andestech.com>2022-11-15 15:37:17 +0800
commitfb103971feb637809a96fe739d81fe2f887cf3ac (patch)
tree7e74590d70d9d998ee97db5e958e0e32324917c1 /drivers/clk/microchip/mpfs_clk_periph.c
parent540d02217f8f997c55818ecd16d8624c520ca750 (diff)
clk: microchip: mpfs: convert parent rate acquistion to get_get_rate()
Currently the clock driver for PolarFire SoC takes a very naive approach to the relationship between clocks. It reads the dt to get an input clock, assumes that that is fixed frequency, reads the "clock-frequency" property & uses that to set up both the "cfg" and "periph" clocks. Simplifying for the sake of incremental fixes, the "correct" parentage for the clocks currently supported in U-Boot is that the "cfg" clocks should be children of the fixed frequency clock in the dt. The AHB clock is one of these "cfg" clocks and is the parent of the "periph" clocks. Instead of passing the clock rate of the fixed-frequency clock to the "cfg" and "periph" registration functions and the name of the parents, pass their actual parents & use clk_get_rate() to determine their parents rates. The "periph" clocks are purely gate clocks and should not be reading the AHB clocks registers to determine their rates, as they can simply report the output of clk_get_rate() on their parent. Signed-off-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com> Reviewed-by: Padmarao Begari <padmarao.begari@microchip.com>
Diffstat (limited to 'drivers/clk/microchip/mpfs_clk_periph.c')
-rw-r--r--drivers/clk/microchip/mpfs_clk_periph.c16
1 files changed, 4 insertions, 12 deletions
diff --git a/drivers/clk/microchip/mpfs_clk_periph.c b/drivers/clk/microchip/mpfs_clk_periph.c
index 61d90eb4a85..1488ef503ed 100644
--- a/drivers/clk/microchip/mpfs_clk_periph.c
+++ b/drivers/clk/microchip/mpfs_clk_periph.c
@@ -99,16 +99,9 @@ static int mpfs_periph_clk_disable(struct clk *hw)
static ulong mpfs_periph_clk_recalc_rate(struct clk *hw)
{
struct mpfs_periph_hw_clock *periph_hw = to_mpfs_periph_clk(hw);
- void __iomem *base_addr = periph_hw->sys_base;
- unsigned long rate;
- u32 val;
- val = readl(base_addr + REG_CLOCK_CONFIG_CR) >> CFG_AHB_SHIFT;
- val &= clk_div_mask(CFG_WIDTH);
- rate = periph_hw->prate / (1u << val);
- hw->rate = rate;
+ return periph_hw->prate;
- return rate;
}
#define CLK_PERIPH(_id, _name, _shift, _flags) { \
@@ -150,8 +143,7 @@ static struct mpfs_periph_hw_clock mpfs_periph_clks[] = {
CLK_PERIPH(CLK_CFM, "clk_periph_cfm", 29, 0),
};
-int mpfs_clk_register_periphs(void __iomem *base, u32 clk_rate,
- const char *parent_name)
+int mpfs_clk_register_periphs(void __iomem *base, struct clk *parent)
{
int ret;
int i, id, num_clks;
@@ -162,9 +154,9 @@ int mpfs_clk_register_periphs(void __iomem *base, u32 clk_rate,
for (i = 0; i < num_clks; i++) {
hw = &mpfs_periph_clks[i].hw;
mpfs_periph_clks[i].sys_base = base;
- mpfs_periph_clks[i].prate = clk_rate;
+ mpfs_periph_clks[i].prate = clk_get_rate(parent);
name = mpfs_periph_clks[i].periph.name;
- ret = clk_register(hw, MPFS_PERIPH_CLOCK, name, parent_name);
+ ret = clk_register(hw, MPFS_PERIPH_CLOCK, name, parent->dev->name);
if (ret)
ERR_PTR(ret);
id = mpfs_periph_clks[i].periph.id;