diff options
| author | mwleeds@mailtundra.com <mwleeds@mailtundra.com> | 2024-04-06 18:47:28 -0700 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2024-04-17 10:08:56 -0600 |
| commit | 1e85ddb784375a20e80a60d185998c2753757616 (patch) | |
| tree | 6c731bfa2287602eccdaf18294c838d3f9af9ab5 /fs/zfs/dev.c | |
| parent | 1fe745b4b92e532b0789f4fe6da6f829bba91417 (diff) | |
zfs: Fix return value of fs_devread()
As evidenced by how other filesystems handle it, a return value of 0
from fs_devread() means failure; nonzero means success. The opposite
assumption was being made in zfs.c for the use of zfs_devread() so fix
the confusion by making zfs_devread() return 0 on success.
It probably doesn't make sense to change the handling of zfs_devread()
in zfs.c instead, because as it is it matches the semantics of the other
functions there.
Signed-off-by: Phaedrus Leeds <mwleeds@mailtundra.com>
Diffstat (limited to 'fs/zfs/dev.c')
| -rw-r--r-- | fs/zfs/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/zfs/dev.c b/fs/zfs/dev.c index 251e7d1f74f..fcd9893b3ac 100644 --- a/fs/zfs/dev.c +++ b/fs/zfs/dev.c @@ -26,5 +26,5 @@ void zfs_set_blk_dev(struct blk_desc *rbdd, struct disk_partition *info) int zfs_devread(int sector, int byte_offset, int byte_len, char *buf) { return fs_devread(zfs_blk_desc, part_info, sector, byte_offset, - byte_len, buf); + byte_len, buf) ? 0 : 1; } |