diff options
| author | Jonas Karlman <jonas@kwiboo.se> | 2024-07-24 22:47:10 +0000 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2024-09-25 08:54:03 -0600 |
| commit | f417c14d88fec5757dbf3cd6af6f7f2ddb99595f (patch) | |
| tree | fe66d51625382c951b3ba1ea03cd2a260ad8ef56 /lib/efi_loader/efi_console.c | |
| parent | 49e3b574ed4f6dc26b65a5d6e9cd14b97e03b861 (diff) | |
power: regulator: Do not call set_suspend_value with -ENODATA
On some boards a PMIC regulator is flagged with regulator-on-in-suspend
and does not define any suspend or max microvolt, e.g. on Radxa ROCK 3A:
vcc_ddr: DCDC_REG3 {
regulator-name = "vcc_ddr";
regulator-always-on;
regulator-boot-on;
regulator-initial-mode = <0x2>;
regulator-state-mem {
regulator-on-in-suspend;
};
};
This result in suspend_uV having the value -ENODATA after probe.
This negative voltage, -ENODATA, gets missinterpreted and result in an
unexpected voltage being set by autoset.
E.g. on Radxa ROCK 3A the vcc_ddr regulator by default have a normal and
suspend voltage value of 0.5v. However, due to this missinterpretation
the suspend voltage end up beind set to 0.5625v instead.
Fix this by skip calling regulator_set_suspend_value() in autoset and
also protect calling set value ops when input value is -ENODATA.
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Diffstat (limited to 'lib/efi_loader/efi_console.c')
0 files changed, 0 insertions, 0 deletions