diff options
author | Sam Protsenko <semen.protsenko@linaro.org> | 2024-11-06 20:58:31 -0600 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2024-11-17 13:13:22 -0600 |
commit | 1070f01ac10abb40b168933de248df76f3e27220 (patch) | |
tree | 0d32a67a72ec25b9fe6031bbb068205724f9ff80 /lib/linux_string.c | |
parent | be48369f32a5831b032b62603fd9634de9302056 (diff) |
armv8: cpu: Implement allow_unaligned()
Usually ARMv8 platforms allow unaligned access for Normal memory. But
some chips might not allow it by default, having SCTLR.A bit set to 1
before U-Boot execution. One such example is Exynos850 SoC. As
allow_unaligned() is not implemented for ARMv8 at the moment, its __weak
implementation is used, which does nothing. That might lead to unaligned
access abort, for example when running EFI selftest. Fix that by
implementing allow_unaligned() for ARMv8.
The issue was found when running EFI selftest on E850-96 board
(Exynos850 based):
=> bootefi selftest $fdtcontroladdr
...
Executing 'HII database protocols'
"Synchronous Abort" handler, esr 0x96000021, far 0xbaac0991
...
resetting ...
Unaligned abort happens in u16_strnlen(), which is called from
efi_hii_sibt_string_ucs2_block_next():
u16_strlen(blk->string_text)
where 'blk' type is struct efi_hii_sibt_string_ucs2_block. Because this
struct is packed, doing "->string_text" makes 'blk' address incremented
by 1 byte, which makes it unaligned. Although allow_unaligned() was
called in efi_init_early() before EFI selftest execution, it wasn't
implemented for ARMv8 CPUs, so data abort happened.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Diffstat (limited to 'lib/linux_string.c')
0 files changed, 0 insertions, 0 deletions