diff options
author | Sean Anderson <seanga2@gmail.com> | 2021-09-11 13:20:00 -0400 |
---|---|---|
committer | Leo Yu-Chi Liang <ycliang@andestech.com> | 2021-10-07 16:08:22 +0800 |
commit | 54d5d2d56bb6c46c996a4d249dbae3b12a7a4fac (patch) | |
tree | 245646fa525ae5f488fac6e32653697aee35e72b /lib/string.c | |
parent | ea67f467a43e4c8852bd1ce1bb75f5dc6c3788d1 (diff) |
clk: k210: Fix checking if ulongs are less than 0
The PLL functions take ulong arguments for rate, but still check if that
rate is negative (which is never true). The correct way to handle this is
to use IS_ERR_VALUE (like is already done in k210_clk_set_rate). While
we're at it, we can move the error checking up into the caller of the pll
set/get rate functions. This also protects our other calculations from
using bogus values for rate.
Fixes: 609bd60b94 ("clk: k210: Rewrite to remove CCF")
Reported-by: Coverity Scan <scan-admin@coverity.com>
Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
Diffstat (limited to 'lib/string.c')
0 files changed, 0 insertions, 0 deletions