summaryrefslogtreecommitdiff
path: root/test/dm/devres.c
diff options
context:
space:
mode:
authorTom Rini <trini@konsulko.com>2022-04-29 11:25:06 -0400
committerTom Rini <trini@konsulko.com>2022-04-29 11:25:06 -0400
commitf7bd9e4936b6e36c2443b9b2ef761e7593511521 (patch)
treef830de0295223e3d938244e60e80a89cdc7f3e91 /test/dm/devres.c
parente95afa56753cebcd20a5114b6d121f281b789006 (diff)
parentd69616e529560ace8cdf40bda91464a88c7ff43a (diff)
Merge branch '2022-04-29-fuzzing-and-asan-fixes'
To quote the author: I've been experimenting with ASAN on sandbox and turned up a few issues that are fixed in this series. Basic ASAN was easy to turn on, but integrating with dlmalloc was messier and fairly intrusive. Even when I had it working, there was only a small redzone between allocations which limits the usefulness. I saw another series on the list by Sean Anderson to enable valgrind which was finding a different set of issues, though there was one overlap that Sean is fixing with "[PATCH] IOMUX: Fix access past end of console_devices". With these issues fixed, I was able to run the dm tests without any ASAN issues. There are a couple of leaks reported at the end, but that's for another day.
Diffstat (limited to 'test/dm/devres.c')
-rw-r--r--test/dm/devres.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/test/dm/devres.c b/test/dm/devres.c
index 4f959d11da9..524114c833c 100644
--- a/test/dm/devres.c
+++ b/test/dm/devres.c
@@ -178,11 +178,8 @@ static int dm_test_devres_phase(struct unit_test_state *uts)
ut_asserteq(1, stats.allocs);
ut_asserteq(TEST_DEVRES_SIZE, stats.total_size);
- /* Unbinding removes the other. Note this access a freed pointer */
+ /* Unbinding removes the other. */
device_unbind(dev);
- devres_get_stats(dev, &stats);
- ut_asserteq(0, stats.allocs);
- ut_asserteq(0, stats.total_size);
return 0;
}