diff options
| author | Haibo Chen <haibo.chen@nxp.com> | 2023-03-27 19:21:43 +0800 |
|---|---|---|
| committer | Heiko Schocher <hs@denx.de> | 2023-04-11 06:44:39 +0200 |
| commit | 7f6a2e6e0f7694bf9557683db1d6ef2fc75ef1c8 (patch) | |
| tree | 778c314948de12bd99adf009bde5c10fb90e2fd9 /test/py/tests/test_shell_basics.py | |
| parent | d600b0fcbbfe877f67fb8b89e4d09aeb376c01d1 (diff) | |
i2c: correct I2C deblock logic
Current code use dm_gpio_get_value() to get SDA and SCL value, and the
value depends on whether DTS file config the GPIO_ACTIVE_LOW. In ususal
case for i2c GPIO, DTS need to set GPIO_ACTIVE_LOW for SCL/SDA pins. So
here the logic is not correct.
And we must not use GPIOD_ACTIVE_LOW in client code include the
dm_gpio_set_dir_flags(), it is DTS's responsibility for this flag. So
remove GPIOD_ACTIVE_LOW here.
Fixes: aa54192d4a87 ("dm: i2c: implement gpio-based I2C deblock")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Reviewed-by: Alexander Kochetkov <al.kochet@gmail.com <mailto:al.kochet@gmail.com>>
Diffstat (limited to 'test/py/tests/test_shell_basics.py')
0 files changed, 0 insertions, 0 deletions