summaryrefslogtreecommitdiff
path: root/tools/buildman/boards.py
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2023-07-19 17:48:26 -0600
committerSimon Glass <sjg@chromium.org>2023-07-24 09:34:10 -0600
commit9a7cc8121f974582d3f07201b3e119e0d7c91559 (patch)
tree7b3c7cb1579be5f776c8a32e3fed5d3ed087cc8f /tools/buildman/boards.py
parent1aaaafadcca2cf6a4203784b8b2b1555c04919e8 (diff)
buildman: Correct logic for missing maintainers
An orphaned board should produce a warning, as should a missing name for the maintainer (when '-' is provided). Add these cases. Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools/buildman/boards.py')
-rw-r--r--tools/buildman/boards.py14
1 files changed, 9 insertions, 5 deletions
diff --git a/tools/buildman/boards.py b/tools/buildman/boards.py
index 269cafa6adc..e608f7990d8 100644
--- a/tools/buildman/boards.py
+++ b/tools/buildman/boards.py
@@ -341,11 +341,15 @@ class MaintainersDatabase:
str: Maintainers of the board. If the board has two or more
maintainers, they are separated with colons.
"""
- if not target in self.database:
- self.warnings.append(f"WARNING: no maintainers for '{target}'")
- return ''
-
- return ':'.join(self.database[target][1])
+ entry = self.database.get(target)
+ if entry:
+ status, maint_list = entry
+ if not status.startswith('Orphan'):
+ if len(maint_list) > 1 or (maint_list and maint_list[0] != '-'):
+ return ':'.join(maint_list)
+
+ self.warnings.append(f"WARNING: no maintainers for '{target}'")
+ return ''
def parse_file(self, srcdir, fname):
"""Parse a MAINTAINERS file.