diff options
| author | Maks Mishin <maks.mishinfz@gmail.com> | 2025-01-22 19:15:04 +0300 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2025-01-26 11:35:46 -0600 |
| commit | f55fa90a959e4644b89c56e692930810c5c462b4 (patch) | |
| tree | 0f6776c235b5eb965ffe77564c14a56a5b3d7e84 /tools/pblimage.c | |
| parent | 61216767209262f5d005a63fb846a808516ff3bf (diff) | |
tools: check result of lseek
Return value of function 'lseek', called at pblimage.c:211,
is not checked, but it is usually checked for this function.
This trigger was found using the Svace static analyzer.
Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Diffstat (limited to 'tools/pblimage.c')
| -rw-r--r-- | tools/pblimage.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/tools/pblimage.c b/tools/pblimage.c index 6c4d360e469..34650cf7b7c 100644 --- a/tools/pblimage.c +++ b/tools/pblimage.c @@ -188,7 +188,7 @@ static void add_end_cmd(void) void pbl_load_uboot(int ifd, struct image_tool_params *params) { FILE *fp_uboot; - int size; + int size, ret; /* parse the rcw.cfg file. */ pbl_parser(params->imagename); @@ -208,7 +208,12 @@ void pbl_load_uboot(int ifd, struct image_tool_params *params) fclose(fp_uboot); } add_end_cmd(); - lseek(ifd, 0, SEEK_SET); + ret = lseek(ifd, 0, SEEK_SET); + if (ret < 0) { + fprintf(stderr, "%s: lseek error %s\n", + __func__, strerror(errno)); + exit(EXIT_FAILURE); + } size = pbl_size; if (write(ifd, (const void *)&mem_buf, size) != size) { |