diff options
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/ata/dwc_ahci.c | 4 | ||||
| -rw-r--r-- | drivers/clk/rockchip/clk_rk3568.c | 1 | ||||
| -rw-r--r-- | drivers/core/read.c | 11 | ||||
| -rw-r--r-- | drivers/mtd/nand/raw/rockchip_nfc.c | 34 | ||||
| -rw-r--r-- | drivers/pci/pcie_dw_common.c | 10 | ||||
| -rw-r--r-- | drivers/pci/pcie_dw_rockchip.c | 98 | ||||
| -rw-r--r-- | drivers/phy/rockchip/Kconfig | 7 | ||||
| -rw-r--r-- | drivers/phy/rockchip/Makefile | 1 | ||||
| -rw-r--r-- | drivers/phy/rockchip/phy-rockchip-usbdp.c | 880 | ||||
| -rw-r--r-- | drivers/power/regulator/fixed.c | 4 | ||||
| -rw-r--r-- | drivers/video/rockchip/dw_mipi_dsi_rockchip.c | 99 | 
11 files changed, 1091 insertions, 58 deletions
| diff --git a/drivers/ata/dwc_ahci.c b/drivers/ata/dwc_ahci.c index 826fea71cc5..1dc91e7fce7 100644 --- a/drivers/ata/dwc_ahci.c +++ b/drivers/ata/dwc_ahci.c @@ -13,7 +13,9 @@  #include <ahci.h>  #include <scsi.h>  #include <sata.h> +#ifdef CONFIG_ARCH_OMAP2PLUS  #include <asm/arch/sata.h> +#endif  #include <asm/io.h>  #include <generic-phy.h> @@ -72,12 +74,14 @@ static int dwc_ahci_probe(struct udevice *dev)  		return ret;  	} +#ifdef CONFIG_ARCH_OMAP2PLUS  	if (priv->wrapper_base) {  		u32 val = TI_SATA_IDLE_NO | TI_SATA_STANDBY_NO;  		/* Enable SATA module, No Idle, No Standby */  		writel(val, priv->wrapper_base + TI_SATA_SYSCONFIG);  	} +#endif  	return ahci_probe_scsi(dev, (ulong)priv->base);  } diff --git a/drivers/clk/rockchip/clk_rk3568.c b/drivers/clk/rockchip/clk_rk3568.c index 6bdd96f35b5..0df82f59715 100644 --- a/drivers/clk/rockchip/clk_rk3568.c +++ b/drivers/clk/rockchip/clk_rk3568.c @@ -427,6 +427,7 @@ static ulong rk3568_pmuclk_set_rate(struct clk *clk, ulong rate)  		break;  	case CLK_PCIEPHY0_REF:  	case CLK_PCIEPHY1_REF: +	case CLK_PCIEPHY2_REF:  		return 0;  	default:  		return -ENOENT; diff --git a/drivers/core/read.c b/drivers/core/read.c index 5749473a6ca..49066b59cda 100644 --- a/drivers/core/read.c +++ b/drivers/core/read.c @@ -150,6 +150,17 @@ fdt_addr_t dev_read_addr_size_index(const struct udevice *dev, int index,  		return devfdt_get_addr_size_index(dev, index, size);  } +void *dev_read_addr_size_index_ptr(const struct udevice *dev, int index, +				   fdt_size_t *size) +{ +	fdt_addr_t addr = dev_read_addr_size_index(dev, index, size); + +	if (addr == FDT_ADDR_T_NONE) +		return NULL; + +	return map_sysmem(addr, 0); +} +  void *dev_remap_addr_index(const struct udevice *dev, int index)  {  	fdt_addr_t addr = dev_read_addr_index(dev, index); diff --git a/drivers/mtd/nand/raw/rockchip_nfc.c b/drivers/mtd/nand/raw/rockchip_nfc.c index 5fcf6a6bfc3..274489ecbc6 100644 --- a/drivers/mtd/nand/raw/rockchip_nfc.c +++ b/drivers/mtd/nand/raw/rockchip_nfc.c @@ -525,7 +525,7 @@ static int rk_nfc_write_page_hwecc(struct mtd_info *mtd,  	int pages_per_blk = mtd->erasesize / mtd->writesize;  	int ret = 0, i, boot_rom_mode = 0;  	dma_addr_t dma_data, dma_oob; -	u32 reg; +	u32 tmp;  	u8 *oob;  	nand_prog_page_begin_op(chip, page, 0, NULL, 0); @@ -552,6 +552,13 @@ static int rk_nfc_write_page_hwecc(struct mtd_info *mtd,  	 *  	 *   0xFF 0xFF 0xFF 0xFF | BBM OOB1 OOB2 OOB3 | ...  	 * +	 * The code here just swaps the first 4 bytes with the last +	 * 4 bytes without losing any data. +	 * +	 * The chip->oob_poi data layout: +	 * +	 *    BBM  OOB1 OOB2 OOB3 |......|  PA0  PA1  PA2  PA3 +	 *  	 * Configure the ECC algorithm supported by the boot ROM.  	 */  	if (page < (pages_per_blk * rknand->boot_blks)) { @@ -561,21 +568,17 @@ static int rk_nfc_write_page_hwecc(struct mtd_info *mtd,  	}  	for (i = 0; i < ecc->steps; i++) { -		if (!i) { -			reg = 0xFFFFFFFF; -		} else { +		if (!i) +			oob = chip->oob_poi + (ecc->steps - 1) * NFC_SYS_DATA_SIZE; +		else  			oob = chip->oob_poi + (i - 1) * NFC_SYS_DATA_SIZE; -			reg = oob[0] | oob[1] << 8 | oob[2] << 16 | -			      oob[3] << 24; -		} -		if (!i && boot_rom_mode) -			reg = (page & (pages_per_blk - 1)) * 4; +		tmp = oob[0] | oob[1] << 8 | oob[2] << 16 | oob[3] << 24;  		if (nfc->cfg->type == NFC_V9) -			nfc->oob_buf[i] = reg; +			nfc->oob_buf[i] = tmp;  		else -			nfc->oob_buf[i * (oob_step / 4)] = reg; +			nfc->oob_buf[i * (oob_step / 4)] = tmp;  	}  	dma_data = dma_map_single((void *)nfc->page_buf, @@ -720,12 +723,17 @@ static int rk_nfc_read_page_hwecc(struct mtd_info *mtd,  		goto timeout_err;  	} -	for (i = 1; i < ecc->steps; i++) { -		oob = chip->oob_poi + (i - 1) * NFC_SYS_DATA_SIZE; +	for (i = 0; i < ecc->steps; i++) { +		if (!i) +			oob = chip->oob_poi + (ecc->steps - 1) * NFC_SYS_DATA_SIZE; +		else +			oob = chip->oob_poi + (i - 1) * NFC_SYS_DATA_SIZE; +  		if (nfc->cfg->type == NFC_V9)  			tmp = nfc->oob_buf[i];  		else  			tmp = nfc->oob_buf[i * (oob_step / 4)]; +  		*oob++ = (u8)tmp;  		*oob++ = (u8)(tmp >> 8);  		*oob++ = (u8)(tmp >> 16); diff --git a/drivers/pci/pcie_dw_common.c b/drivers/pci/pcie_dw_common.c index 9f8b016d114..74fb6df412c 100644 --- a/drivers/pci/pcie_dw_common.c +++ b/drivers/pci/pcie_dw_common.c @@ -141,9 +141,9 @@ static uintptr_t set_cfg_address(struct pcie_dw *pcie,  	/*  	 * Not accessing root port configuration space? -	 * Region #0 is used for Outbound CFG space access. +	 * Region #1 is used for Outbound CFG space access.  	 * Direction = Outbound -	 * Region Index = 0 +	 * Region Index = 1  	 */  	d = PCI_MASK_BUS(d);  	d = PCI_ADD_BUS(bus, d); @@ -328,8 +328,10 @@ void pcie_dw_setup_host(struct pcie_dw *pci)  			pci->prefetch.bus_start = hose->regions[ret].bus_start;  /* PREFETCH_bus_addr */  			pci->prefetch.size = hose->regions[ret].size;	    /* PREFETCH size */  		} else if (hose->regions[ret].flags == PCI_REGION_SYS_MEMORY) { -			pci->cfg_base = (void *)(pci->io.phys_start - pci->io.size); -			pci->cfg_size = pci->io.size; +			if (!pci->cfg_base) { +				pci->cfg_base = (void *)(pci->io.phys_start - pci->io.size); +				pci->cfg_size = pci->io.size; +			}  		} else {  			dev_err(pci->dev, "invalid flags type!\n");  		} diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c index 6da618055cb..1a35fae5c3a 100644 --- a/drivers/pci/pcie_dw_rockchip.c +++ b/drivers/pci/pcie_dw_rockchip.c @@ -61,8 +61,7 @@ struct rk_pcie {  #define PCIE_CLIENT_DBG_TRANSITION_DATA	0xffff0000  #define PCIE_CLIENT_DBF_EN		0xffff0003 -/* Parameters for the waiting for #perst signal */ -#define MACRO_US			1000 +#define PCIE_TYPE0_HDR_DBI2_OFFSET	0x100000  static int rk_pcie_read(void __iomem *addr, int size, u32 *val)  { @@ -161,6 +160,12 @@ static void rk_pcie_configure(struct rk_pcie *pci, u32 cap_speed)  {  	dw_pcie_dbi_write_enable(&pci->dw, true); +	/* Disable BAR 0 and BAR 1 */ +	writel(0, pci->dw.dbi_base + PCIE_TYPE0_HDR_DBI2_OFFSET + +	       PCI_BASE_ADDRESS_0); +	writel(0, pci->dw.dbi_base + PCIE_TYPE0_HDR_DBI2_OFFSET + +	       PCI_BASE_ADDRESS_1); +  	clrsetbits_le32(pci->dw.dbi_base + PCIE_LINK_CAPABILITY,  			TARGET_LINK_SPEED_MASK, cap_speed); @@ -242,43 +247,46 @@ static int rk_pcie_link_up(struct rk_pcie *priv, u32 cap_speed)  	/* DW pre link configurations */  	rk_pcie_configure(priv, cap_speed); -	/* Rest the device */ -	if (dm_gpio_is_valid(&priv->rst_gpio)) { -		dm_gpio_set_value(&priv->rst_gpio, 0); -		/* -		 * Minimal is 100ms from spec but we see -		 * some wired devices need much more, such as 600ms. -		 * Add a enough delay to cover all cases. -		 */ -		udelay(MACRO_US * 1000); -		dm_gpio_set_value(&priv->rst_gpio, 1); -	} -  	rk_pcie_disable_ltssm(priv);  	rk_pcie_link_status_clear(priv);  	rk_pcie_enable_debug(priv); +	/* Reset the device */ +	if (dm_gpio_is_valid(&priv->rst_gpio)) +		dm_gpio_set_value(&priv->rst_gpio, 0); +  	/* Enable LTSSM */  	rk_pcie_enable_ltssm(priv); -	for (retries = 0; retries < 5; retries++) { -		if (is_link_up(priv)) { -			dev_info(priv->dw.dev, "PCIe Link up, LTSSM is 0x%x\n", -				 rk_pcie_readl_apb(priv, PCIE_CLIENT_LTSSM_STATUS)); -			rk_pcie_debug_dump(priv); -			return 0; -		} - -		dev_info(priv->dw.dev, "PCIe Linking... LTSSM is 0x%x\n", -			 rk_pcie_readl_apb(priv, PCIE_CLIENT_LTSSM_STATUS)); -		rk_pcie_debug_dump(priv); -		udelay(MACRO_US * 1000); +	/* +	 * PCIe requires the refclk to be stable for 100ms prior to releasing +	 * PERST. See table 2-4 in section 2.6.2 AC Specifications of the PCI +	 * Express Card Electromechanical Specification, 1.1. However, we don't +	 * know if the refclk is coming from RC's PHY or external OSC. If it's +	 * from RC, so enabling LTSSM is the just right place to release #PERST. +	 */ +	mdelay(100); +	if (dm_gpio_is_valid(&priv->rst_gpio)) +		dm_gpio_set_value(&priv->rst_gpio, 1); + +	/* Check if the link is up or not */ +	for (retries = 0; retries < 10; retries++) { +		if (is_link_up(priv)) +			break; + +		mdelay(100); +	} + +	if (retries >= 10) { +		dev_err(priv->dw.dev, "PCIe-%d Link Fail\n", +			dev_seq(priv->dw.dev)); +		return -EIO;  	} -	dev_err(priv->dw.dev, "PCIe-%d Link Fail\n", dev_seq(priv->dw.dev)); -	/* Link maybe in Gen switch recovery but we need to wait more 1s */ -	udelay(MACRO_US * 1000); -	return -EIO; +	dev_info(priv->dw.dev, "PCIe Link up, LTSSM is 0x%x\n", +		 rk_pcie_readl_apb(priv, PCIE_CLIENT_LTSSM_STATUS)); +	rk_pcie_debug_dump(priv); +	return 0;  }  static int rockchip_pcie_init_port(struct udevice *dev) @@ -287,22 +295,23 @@ static int rockchip_pcie_init_port(struct udevice *dev)  	u32 val;  	struct rk_pcie *priv = dev_get_priv(dev); -	/* Set power and maybe external ref clk input */ -	if (priv->vpcie3v3) { -		ret = regulator_set_value(priv->vpcie3v3, 3300000); -		if (ret) { -			dev_err(priv->dw.dev, "failed to enable vpcie3v3 (ret=%d)\n", -				ret); -			return ret; -		} +	ret = reset_assert_bulk(&priv->rsts); +	if (ret) { +		dev_err(dev, "failed to assert resets (ret=%d)\n", ret); +		return ret;  	} -	udelay(MACRO_US * 1000); +	/* Set power and maybe external ref clk input */ +	ret = regulator_set_enable_if_allowed(priv->vpcie3v3, true); +	if (ret && ret != -ENOSYS) { +		dev_err(dev, "failed to enable vpcie3v3 (ret=%d)\n", ret); +		return ret; +	}  	ret = generic_phy_init(&priv->phy);  	if (ret) {  		dev_err(dev, "failed to init phy (ret=%d)\n", ret); -		return ret; +		goto err_disable_regulator;  	}  	ret = generic_phy_power_on(&priv->phy); @@ -345,6 +354,8 @@ err_power_off_phy:  	generic_phy_power_off(&priv->phy);  err_exit_phy:  	generic_phy_exit(&priv->phy); +err_disable_regulator: +	regulator_set_enable_if_allowed(priv->vpcie3v3, false);  	return ret;  } @@ -366,6 +377,13 @@ static int rockchip_pcie_parse_dt(struct udevice *dev)  	dev_dbg(dev, "APB address is 0x%p\n", priv->apb_base); +	priv->dw.cfg_base = dev_read_addr_size_index_ptr(dev, 2, +							 &priv->dw.cfg_size); +	if (!priv->dw.cfg_base) +		return -EINVAL; + +	dev_dbg(dev, "CFG address is 0x%p\n", priv->dw.cfg_base); +  	ret = gpio_request_by_name(dev, "reset-gpios", 0,  				   &priv->rst_gpio, GPIOD_IS_OUT);  	if (ret) { diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig index f87ca8c3106..0247d93ab40 100644 --- a/drivers/phy/rockchip/Kconfig +++ b/drivers/phy/rockchip/Kconfig @@ -41,6 +41,13 @@ config PHY_ROCKCHIP_SNPS_PCIE3  	  It could support PCIe Gen3 single root complex, and could  	  also be able splited into multiple combinations of lanes. +config PHY_ROCKCHIP_USBDP +	tristate "Rockchip USBDP COMBO PHY Driver" +	depends on ARCH_ROCKCHIP +	select PHY +	help +	  Enable this to support the Rockchip USB3.0/DP +	  combo PHY with Samsung IP block.  config PHY_ROCKCHIP_TYPEC  	bool "Rockchip TYPEC PHY Driver" diff --git a/drivers/phy/rockchip/Makefile b/drivers/phy/rockchip/Makefile index 25a803a8a86..7fdbd107976 100644 --- a/drivers/phy/rockchip/Makefile +++ b/drivers/phy/rockchip/Makefile @@ -9,3 +9,4 @@ obj-$(CONFIG_PHY_ROCKCHIP_PCIE)		+= phy-rockchip-pcie.o  obj-$(CONFIG_PHY_ROCKCHIP_SNPS_PCIE3)	+= phy-rockchip-snps-pcie3.o  obj-$(CONFIG_PHY_ROCKCHIP_TYPEC)	+= phy-rockchip-typec.o  obj-$(CONFIG_PHY_ROCKCHIP_INNO_DSIDPHY)	+= phy-rockchip-inno-dsidphy.o +obj-$(CONFIG_PHY_ROCKCHIP_USBDP) += phy-rockchip-usbdp.o diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c new file mode 100644 index 00000000000..baf92529348 --- /dev/null +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c @@ -0,0 +1,880 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Rockchip USBDP Combo PHY with Samsung IP block driver + * + * Copyright (C) 2021 Rockchip Electronics Co., Ltd + */ + +#include <common.h> +#include <clk.h> +#include <dm.h> +#include <dm/device_compat.h> +#include <dm/devres.h> +#include <dm/lists.h> +#include <dm/of.h> +#include <dm/of_access.h> +#include <generic-phy.h> +#include <linux/bitfield.h> +#include <linux/usb/ch9.h> +#include <linux/usb/otg.h> +#include <regmap.h> +#include <reset.h> +#include <syscon.h> +#include <asm/arch-rockchip/clock.h> + +#include <linux/usb/phy-rockchip-usbdp.h> + +#define BIT_WRITEABLE_SHIFT	16 + +enum { +	UDPHY_MODE_NONE		= 0, +	UDPHY_MODE_USB		= BIT(0), +	UDPHY_MODE_DP		= BIT(1), +	UDPHY_MODE_DP_USB	= BIT(1) | BIT(0), +}; + +struct udphy_grf_reg { +	unsigned int	offset; +	unsigned int	bitend; +	unsigned int	bitstart; +	unsigned int	disable; +	unsigned int	enable; +}; + +/** + * struct reg_sequence - An individual write from a sequence of writes. + * + * @reg: Register address. + * @def: Register value. + * @delay_us: Delay to be applied after the register write in microseconds + * + * Register/value pairs for sequences of writes with an optional delay in + * microseconds to be applied after each write. + */ +struct reg_sequence { +	unsigned int reg; +	unsigned int def; +	unsigned int delay_us; +}; + +struct udphy_grf_cfg { +	/* u2phy-grf */ +	struct udphy_grf_reg	bvalid_phy_con; +	struct udphy_grf_reg	bvalid_grf_con; + +	/* usb-grf */ +	struct udphy_grf_reg	usb3otg0_cfg; +	struct udphy_grf_reg	usb3otg1_cfg; + +	/* usbdpphy-grf */ +	struct udphy_grf_reg	low_pwrn; +	struct udphy_grf_reg	rx_lfps; +}; + +struct rockchip_udphy; + +struct rockchip_udphy_cfg { +	/* resets to be requested */ +	const char * const *rst_list; +	int num_rsts; + +	struct udphy_grf_cfg grfcfg; +	int (*combophy_init)(struct rockchip_udphy *udphy); +}; + +struct rockchip_udphy { +	struct udevice *dev; +	struct regmap *pma_regmap; +	struct regmap *u2phygrf; +	struct regmap *udphygrf; +	struct regmap *usbgrf; +	struct regmap *vogrf; + +	/* clocks and rests */ +	struct reset_ctl *rsts; + +	/* PHY status management */ +	bool flip; +	bool mode_change; +	u8 mode; +	u8 status; + +	/* utilized for USB */ +	bool hs; /* flag for high-speed */ + +	/* utilized for DP */ +	struct gpio_desc *sbu1_dc_gpio; +	struct gpio_desc *sbu2_dc_gpio; +	u32 lane_mux_sel[4]; +	u32 dp_lane_sel[4]; +	u32 dp_aux_dout_sel; +	u32 dp_aux_din_sel; +	int id; + +	/* PHY const config */ +	const struct rockchip_udphy_cfg *cfgs; +}; + +static const struct reg_sequence rk3588_udphy_24m_refclk_cfg[] = { +	{0x0090, 0x68}, {0x0094, 0x68}, +	{0x0128, 0x24}, {0x012c, 0x44}, +	{0x0130, 0x3f}, {0x0134, 0x44}, +	{0x015c, 0xa9}, {0x0160, 0x71}, +	{0x0164, 0x71}, {0x0168, 0xa9}, +	{0x0174, 0xa9}, {0x0178, 0x71}, +	{0x017c, 0x71}, {0x0180, 0xa9}, +	{0x018c, 0x41}, {0x0190, 0x00}, +	{0x0194, 0x05}, {0x01ac, 0x2a}, +	{0x01b0, 0x17}, {0x01b4, 0x17}, +	{0x01b8, 0x2a}, {0x01c8, 0x04}, +	{0x01cc, 0x08}, {0x01d0, 0x08}, +	{0x01d4, 0x04}, {0x01d8, 0x20}, +	{0x01dc, 0x01}, {0x01e0, 0x09}, +	{0x01e4, 0x03}, {0x01f0, 0x29}, +	{0x01f4, 0x02}, {0x01f8, 0x02}, +	{0x01fc, 0x29}, {0x0208, 0x2a}, +	{0x020c, 0x17}, {0x0210, 0x17}, +	{0x0214, 0x2a}, {0x0224, 0x20}, +	{0x03f0, 0x0d}, {0x03f4, 0x09}, +	{0x03f8, 0x09}, {0x03fc, 0x0d}, +	{0x0404, 0x0e}, {0x0408, 0x14}, +	{0x040c, 0x14}, {0x0410, 0x3b}, +	{0x0ce0, 0x68}, {0x0ce8, 0xd0}, +	{0x0cf0, 0x87}, {0x0cf8, 0x70}, +	{0x0d00, 0x70}, {0x0d08, 0xa9}, +	{0x1ce0, 0x68}, {0x1ce8, 0xd0}, +	{0x1cf0, 0x87}, {0x1cf8, 0x70}, +	{0x1d00, 0x70}, {0x1d08, 0xa9}, +	{0x0a3c, 0xd0}, {0x0a44, 0xd0}, +	{0x0a48, 0x01}, {0x0a4c, 0x0d}, +	{0x0a54, 0xe0}, {0x0a5c, 0xe0}, +	{0x0a64, 0xa8}, {0x1a3c, 0xd0}, +	{0x1a44, 0xd0}, {0x1a48, 0x01}, +	{0x1a4c, 0x0d}, {0x1a54, 0xe0}, +	{0x1a5c, 0xe0}, {0x1a64, 0xa8} +}; + +static const struct reg_sequence rk3588_udphy_init_sequence[] = { +	{0x0104, 0x44}, {0x0234, 0xE8}, +	{0x0248, 0x44}, {0x028C, 0x18}, +	{0x081C, 0xE5}, {0x0878, 0x00}, +	{0x0994, 0x1C}, {0x0AF0, 0x00}, +	{0x181C, 0xE5}, {0x1878, 0x00}, +	{0x1994, 0x1C}, {0x1AF0, 0x00}, +	{0x0428, 0x60}, {0x0D58, 0x33}, +	{0x1D58, 0x33}, {0x0990, 0x74}, +	{0x0D64, 0x17}, {0x08C8, 0x13}, +	{0x1990, 0x74}, {0x1D64, 0x17}, +	{0x18C8, 0x13}, {0x0D90, 0x40}, +	{0x0DA8, 0x40}, {0x0DC0, 0x40}, +	{0x0DD8, 0x40}, {0x1D90, 0x40}, +	{0x1DA8, 0x40}, {0x1DC0, 0x40}, +	{0x1DD8, 0x40}, {0x03C0, 0x30}, +	{0x03C4, 0x06}, {0x0E10, 0x00}, +	{0x1E10, 0x00}, {0x043C, 0x0F}, +	{0x0D2C, 0xFF}, {0x1D2C, 0xFF}, +	{0x0D34, 0x0F}, {0x1D34, 0x0F}, +	{0x08FC, 0x2A}, {0x0914, 0x28}, +	{0x0A30, 0x03}, {0x0E38, 0x05}, +	{0x0ECC, 0x27}, {0x0ED0, 0x22}, +	{0x0ED4, 0x26}, {0x18FC, 0x2A}, +	{0x1914, 0x28}, {0x1A30, 0x03}, +	{0x1E38, 0x05}, {0x1ECC, 0x27}, +	{0x1ED0, 0x22}, {0x1ED4, 0x26}, +	{0x0048, 0x0F}, {0x0060, 0x3C}, +	{0x0064, 0xF7}, {0x006C, 0x20}, +	{0x0070, 0x7D}, {0x0074, 0x68}, +	{0x0AF4, 0x1A}, {0x1AF4, 0x1A}, +	{0x0440, 0x3F}, {0x10D4, 0x08}, +	{0x20D4, 0x08}, {0x00D4, 0x30}, +	{0x0024, 0x6e}, +}; + +static inline int grfreg_write(struct regmap *base, +			       const struct udphy_grf_reg *reg, bool en) +{ +	u32 val, mask, tmp; + +	tmp = en ? reg->enable : reg->disable; +	mask = GENMASK(reg->bitend, reg->bitstart); +	val = (tmp << reg->bitstart) | (mask << BIT_WRITEABLE_SHIFT); + +	return regmap_write(base, reg->offset, val); +} + +static int __regmap_multi_reg_write(struct regmap *map, +				    const struct reg_sequence *regs, +				    int num_regs) +{ +	int i, ret = 0; + +	for (i = 0; i < num_regs; i++) { +		ret = regmap_write(map, regs[i].reg, regs[i].def); + +		if (regs[i].delay_us) +			udelay(regs[i].delay_us); +	} + +	return ret; +} + +static int udphy_clk_init(struct rockchip_udphy *udphy, struct udevice *dev) +{ +	return 0; +} + +static int udphy_reset_init(struct rockchip_udphy *udphy, struct udevice *dev) +{ +	const struct rockchip_udphy_cfg *cfg = udphy->cfgs; +	int idx; +	int ret; + +	udphy->rsts = devm_kcalloc(dev, cfg->num_rsts, +				   sizeof(*udphy->rsts), GFP_KERNEL); +	if (!udphy->rsts) +		return -ENOMEM; + +	for (idx = 0; idx < cfg->num_rsts; idx++) { +		const char *name = cfg->rst_list[idx]; + +		ret = reset_get_by_name(dev, name, &udphy->rsts[idx]); +		if (ret) { +			dev_err(dev, "failed to get %s reset\n", name); +			goto err; +		} + +		reset_assert(&udphy->rsts[idx]); +	} + +	return 0; + +err: +	devm_kfree(dev, udphy->rsts); +	return ret; +} + +static int udphy_get_rst_idx(const char * const *list, int num, char *name) +{ +	int idx; + +	for (idx = 0; idx < num; idx++) { +		if (!strcmp(list[idx], name)) +			return idx; +	} + +	return -EINVAL; +} + +static int udphy_reset_assert(struct rockchip_udphy *udphy, char *name) +{ +	const struct rockchip_udphy_cfg *cfg = udphy->cfgs; +	int idx; + +	idx = udphy_get_rst_idx(cfg->rst_list, cfg->num_rsts, name); +	if (idx < 0) +		return idx; + +	return reset_assert(&udphy->rsts[idx]); +} + +static int udphy_reset_deassert(struct rockchip_udphy *udphy, char *name) +{ +	const struct rockchip_udphy_cfg *cfg = udphy->cfgs; +	int idx; + +	idx = udphy_get_rst_idx(cfg->rst_list, cfg->num_rsts, name); +	if (idx < 0) +		return idx; + +	return reset_deassert(&udphy->rsts[idx]); +} + +static void udphy_u3_port_disable(struct rockchip_udphy *udphy, u8 disable) +{ +	const struct rockchip_udphy_cfg *cfg = udphy->cfgs; +	const struct udphy_grf_reg *preg; + +	preg = udphy->id ? &cfg->grfcfg.usb3otg1_cfg : &cfg->grfcfg.usb3otg0_cfg; +	grfreg_write(udphy->usbgrf, preg, disable); +} + +__maybe_unused +static void udphy_usb_bvalid_enable(struct rockchip_udphy *udphy, u8 enable) +{ +	const struct rockchip_udphy_cfg *cfg = udphy->cfgs; + +	grfreg_write(udphy->u2phygrf, &cfg->grfcfg.bvalid_phy_con, enable); +	grfreg_write(udphy->u2phygrf, &cfg->grfcfg.bvalid_grf_con, enable); +} + +/* + * In usb/dp combo phy driver, here are 2 ways to mapping lanes. + * + * 1 Type-C Mapping table (DP_Alt_Mode V1.0b remove ABF pin mapping) + * --------------------------------------------------------------------------- + * Type-C Pin   B11-B10       A2-A3       A11-A10       B2-B3 + * PHY Pad      ln0(tx/rx)    ln1(tx)     ln2(tx/rx)    ln3(tx) + * C/E(Normal)  dpln3         dpln2       dpln0         dpln1 + * C/E(Flip  )  dpln0         dpln1       dpln3         dpln2 + * D/F(Normal)  usbrx         usbtx       dpln0         dpln1 + * D/F(Flip  )  dpln0         dpln1       usbrx         usbtx + * A(Normal  )  dpln3         dpln1       dpln2         dpln0 + * A(Flip    )  dpln2         dpln0       dpln3         dpln1 + * B(Normal  )  usbrx         usbtx       dpln1         dpln0 + * B(Flip    )  dpln1         dpln0       usbrx         usbtx + * --------------------------------------------------------------------------- + * + * 2 Mapping the lanes in dtsi + * if all 4 lane assignment for dp function, define rockchip,dp-lane-mux = <x x x x>; + * sample as follow: + * --------------------------------------------------------------------------- + *                        B11-B10       A2-A3       A11-A10       B2-B3 + * rockchip,dp-lane-mux   ln0(tx/rx)    ln1(tx)     ln2(tx/rx)    ln3(tx) + * <0 1 2 3>              dpln0         dpln1       dpln2         dpln3 + * <2 3 0 1>              dpln2         dpln3       dpln0         dpln1 + * --------------------------------------------------------------------------- + * if 2 lane for dp function, 2 lane for usb function, define rockchip,dp-lane-mux = <x x>; + * sample as follow: + * --------------------------------------------------------------------------- + *                        B11-B10       A2-A3       A11-A10       B2-B3 + * rockchip,dp-lane-mux   ln0(tx/rx)    ln1(tx)     ln2(tx/rx)    ln3(tx) + * <0 1>                  dpln0         dpln1       usbrx         usbtx + * <2 3>                  usbrx         usbtx       dpln0         dpln1 + * --------------------------------------------------------------------------- + */ + +__maybe_unused +static int upphy_set_typec_default_mapping(struct rockchip_udphy *udphy) +{ +	if (udphy->flip) { +		udphy->dp_lane_sel[0] = 0; +		udphy->dp_lane_sel[1] = 1; +		udphy->dp_lane_sel[2] = 3; +		udphy->dp_lane_sel[3] = 2; +		udphy->lane_mux_sel[0] = PHY_LANE_MUX_DP; +		udphy->lane_mux_sel[1] = PHY_LANE_MUX_DP; +		udphy->lane_mux_sel[2] = PHY_LANE_MUX_USB; +		udphy->lane_mux_sel[3] = PHY_LANE_MUX_USB; +		udphy->dp_aux_dout_sel = PHY_AUX_DP_DATA_POL_INVERT; +		udphy->dp_aux_din_sel = PHY_AUX_DP_DATA_POL_INVERT; +	} else { +		udphy->dp_lane_sel[0] = 2; +		udphy->dp_lane_sel[1] = 3; +		udphy->dp_lane_sel[2] = 1; +		udphy->dp_lane_sel[3] = 0; +		udphy->lane_mux_sel[0] = PHY_LANE_MUX_USB; +		udphy->lane_mux_sel[1] = PHY_LANE_MUX_USB; +		udphy->lane_mux_sel[2] = PHY_LANE_MUX_DP; +		udphy->lane_mux_sel[3] = PHY_LANE_MUX_DP; +		udphy->dp_aux_dout_sel = PHY_AUX_DP_DATA_POL_NORMAL; +		udphy->dp_aux_din_sel = PHY_AUX_DP_DATA_POL_NORMAL; +	} + +	udphy->mode = UDPHY_MODE_DP_USB; + +	return 0; +} + +static int udphy_setup(struct rockchip_udphy *udphy) +{ +	const struct rockchip_udphy_cfg *cfg = udphy->cfgs; +	int ret = 0; + +	if (cfg->combophy_init) { +		ret = cfg->combophy_init(udphy); +		if (ret) +			dev_err(udphy->dev, "failed to init usbdp combophy\n"); +	} + +	return ret; +} + +static int udphy_disable(struct rockchip_udphy *udphy) +{ +	const struct rockchip_udphy_cfg *cfg = udphy->cfgs; +	int i; + +	for (i = 0; i < cfg->num_rsts; i++) +		reset_assert(&udphy->rsts[i]); + +	return 0; +} + +static int udphy_parse_lane_mux_data(struct rockchip_udphy *udphy, +				     const struct device_node *np) +{ +	struct property *prop; +	int ret, i, len, num_lanes; + +	prop = of_find_property(np, "rockchip,dp-lane-mux", &len); +	if (!prop) { +		dev_dbg(udphy->dev, +			"failed to find dp lane mux, following dp alt mode\n"); +		udphy->mode = UDPHY_MODE_USB; +		return 0; +	} + +	num_lanes = len / sizeof(u32); + +	if (num_lanes != 2 && num_lanes != 4) { +		dev_err(udphy->dev, "invalid number of lane mux\n"); +		return -EINVAL; +	} + +	ret = of_read_u32_array(np, "rockchip,dp-lane-mux", udphy->dp_lane_sel, +				num_lanes); +	if (ret) { +		dev_err(udphy->dev, "get dp lane mux failed\n"); +		return -EINVAL; +	} + +	for (i = 0; i < num_lanes; i++) { +		int j; + +		if (udphy->dp_lane_sel[i] > 3) { +			dev_err(udphy->dev, +				"lane mux between 0 and 3, exceeding the range\n"); +			return -EINVAL; +		} + +		udphy->lane_mux_sel[udphy->dp_lane_sel[i]] = PHY_LANE_MUX_DP; + +		for (j = i + 1; j < num_lanes; j++) { +			if (udphy->dp_lane_sel[i] == udphy->dp_lane_sel[j]) { +				dev_err(udphy->dev, +					"set repeat lane mux value\n"); +				return -EINVAL; +			} +		} +	} + +	udphy->mode = UDPHY_MODE_DP; +	if (num_lanes == 2) +		udphy->mode |= UDPHY_MODE_USB; + +	return 0; +} + +static int udphy_parse_dt(struct rockchip_udphy *udphy, struct udevice *dev) +{ +	const struct device_node *np = ofnode_to_np(dev_ofnode(dev)); +	enum usb_device_speed maximum_speed; +	int ret; + +	udphy->u2phygrf = syscon_regmap_lookup_by_phandle(dev, +							  "rockchip,u2phy-grf"); +	if (IS_ERR(udphy->u2phygrf)) { +		if (PTR_ERR(udphy->u2phygrf) == -ENODEV) { +			dev_warn(dev, "missing u2phy-grf dt node\n"); +			udphy->u2phygrf = NULL; +		} else { +			return PTR_ERR(udphy->u2phygrf); +		} +	} + +	udphy->udphygrf = syscon_regmap_lookup_by_phandle(dev, +							  "rockchip,usbdpphy-grf"); +	if (IS_ERR(udphy->udphygrf)) { +		if (PTR_ERR(udphy->udphygrf) == -ENODEV) { +			dev_warn(dev, "missing usbdpphy-grf dt node\n"); +			udphy->udphygrf = NULL; +		} else { +			return PTR_ERR(udphy->udphygrf); +		} +	} + +	udphy->usbgrf = syscon_regmap_lookup_by_phandle(dev, +							"rockchip,usb-grf"); +	if (IS_ERR(udphy->usbgrf)) { +		if (PTR_ERR(udphy->usbgrf) == -ENODEV) { +			dev_warn(dev, "missing usb-grf dt node\n"); +			udphy->usbgrf = NULL; +		} else { +			return PTR_ERR(udphy->usbgrf); +		} +	} + +	udphy->vogrf = syscon_regmap_lookup_by_phandle(dev, "rockchip,vo-grf"); +	if (IS_ERR(udphy->vogrf)) { +		if (PTR_ERR(udphy->vogrf) == -ENODEV) { +			dev_warn(dev, "missing vo-grf dt node\n"); +			udphy->vogrf = NULL; +		} else { +			return PTR_ERR(udphy->vogrf); +		} +	} + +	ret = udphy_parse_lane_mux_data(udphy, np); +	if (ret) +		return ret; + +	if (dev_read_prop(dev, "maximum-speed", NULL)) { +		maximum_speed = usb_get_maximum_speed(dev_ofnode(dev)); +		udphy->hs = maximum_speed <= USB_SPEED_HIGH ? true : false; +	} + +	ret = udphy_clk_init(udphy, dev); +	if (ret) +		return ret; + +	ret = udphy_reset_init(udphy, dev); +	if (ret) +		return ret; + +	return 0; +} + +static int udphy_power_on(struct rockchip_udphy *udphy, u8 mode) +{ +	int ret; + +	if (!(udphy->mode & mode)) { +		dev_info(udphy->dev, "mode 0x%02x is not support\n", mode); +		return 0; +	} + +	if (udphy->status == UDPHY_MODE_NONE) { +		udphy->mode_change = false; +		ret = udphy_setup(udphy); +		if (ret) +			return ret; + +		if (udphy->mode & UDPHY_MODE_USB) +			udphy_u3_port_disable(udphy, false); +	} else if (udphy->mode_change) { +		udphy->mode_change = false; +		udphy->status = UDPHY_MODE_NONE; +		if (udphy->mode == UDPHY_MODE_DP) +			udphy_u3_port_disable(udphy, true); + +		ret = udphy_disable(udphy); +		if (ret) +			return ret; +		ret = udphy_setup(udphy); +		if (ret) +			return ret; +	} + +	udphy->status |= mode; + +	return 0; +} + +static int udphy_power_off(struct rockchip_udphy *udphy, u8 mode) +{ +	int ret; + +	if (!(udphy->mode & mode)) { +		dev_info(udphy->dev, "mode 0x%02x is not supported\n", mode); +		return 0; +	} + +	if (!udphy->status) +		return 0; + +	udphy->status &= ~mode; + +	if (udphy->status == UDPHY_MODE_NONE) { +		ret = udphy_disable(udphy); +		if (ret) +			return ret; +	} + +	return 0; +} + +static int rockchip_u3phy_init(struct phy *phy) +{ +	struct udevice *parent = phy->dev->parent; +	struct rockchip_udphy *udphy = dev_get_priv(parent); + +	/* DP only or high-speed, disable U3 port */ +	if (!(udphy->mode & UDPHY_MODE_USB) || udphy->hs) { +		udphy_u3_port_disable(udphy, true); +		return 0; +	} + +	return udphy_power_on(udphy, UDPHY_MODE_USB); +} + +static int rockchip_u3phy_exit(struct phy *phy) +{ +	struct udevice *parent = phy->dev->parent; +	struct rockchip_udphy *udphy = dev_get_priv(parent); + +	/* DP only or high-speed */ +	if (!(udphy->mode & UDPHY_MODE_USB) || udphy->hs) +		return 0; + +	return udphy_power_off(udphy, UDPHY_MODE_USB); +} + +static const struct phy_ops rockchip_u3phy_ops = { +	.init		= rockchip_u3phy_init, +	.exit		= rockchip_u3phy_exit, +}; + +int rockchip_u3phy_uboot_init(void) +{ +	struct udevice *udev; +	struct rockchip_udphy *udphy; +	int ret; + +	ret = uclass_get_device_by_driver(UCLASS_PHY, +					  DM_DRIVER_GET(rockchip_udphy_u3_port), +					  &udev); +	if (ret) { +		pr_err("%s: get u3-port failed: %d\n", __func__, ret); +		return ret; +	} + +	/* DP only or high-speed, disable U3 port */ +	udphy = dev_get_priv(udev->parent); +	if (!(udphy->mode & UDPHY_MODE_USB) || udphy->hs) { +		udphy_u3_port_disable(udphy, true); +		return 0; +	} + +	return udphy_power_on(udphy, UDPHY_MODE_USB); +} + +static int rockchip_udphy_probe(struct udevice *dev) +{ +	const struct device_node *np = ofnode_to_np(dev_ofnode(dev)); +	struct rockchip_udphy *udphy = dev_get_priv(dev); +	const struct rockchip_udphy_cfg *phy_cfgs; +	int id, ret; + +	udphy->dev = dev; + +	id = of_alias_get_id(np, "usbdp"); +	if (id < 0) +		id = 0; +	udphy->id = id; + +	phy_cfgs = (const struct rockchip_udphy_cfg *)dev_get_driver_data(dev); +	if (!phy_cfgs) { +		dev_err(dev, "unable to get phy_cfgs\n"); +		return -EINVAL; +	} +	udphy->cfgs = phy_cfgs; + +	ret = regmap_init_mem(dev_ofnode(dev), &udphy->pma_regmap); +	if (ret) +		return ret; +	udphy->pma_regmap->ranges[0].start += UDPHY_PMA; + +	ret = udphy_parse_dt(udphy, dev); +	if (ret) +		return ret; + +	return 0; +} + +static int rockchip_udphy_bind(struct udevice *parent) +{ +	struct udevice *child; +	ofnode subnode; +	const char *node_name; +	int ret; + +	dev_for_each_subnode(subnode, parent) { +		if (!ofnode_valid(subnode)) { +			printf("%s: no subnode for %s", __func__, parent->name); +			return -ENXIO; +		} + +		node_name = ofnode_get_name(subnode); +		debug("%s: subnode %s\n", __func__, node_name); + +		/* if there is no match, continue */ +		if (strcasecmp(node_name, "usb3-port")) +			continue; + +		/* node name is usb3-port */ +		ret = device_bind_driver_to_node(parent, +						 "rockchip_udphy_u3_port", +						 node_name, subnode, &child); +		if (ret) { +			printf("%s: '%s' cannot bind its driver\n", +			       __func__, node_name); +			return ret; +		} +	} + +	return 0; +} + +static int rk3588_udphy_refclk_set(struct rockchip_udphy *udphy) +{ +	/* configure phy reference clock */ +	return __regmap_multi_reg_write(udphy->pma_regmap, +					rk3588_udphy_24m_refclk_cfg, +					ARRAY_SIZE(rk3588_udphy_24m_refclk_cfg)); +} + +static int rk3588_udphy_status_check(struct rockchip_udphy *udphy) +{ +	unsigned int val; +	int ret; + +	if (!(udphy->mode & UDPHY_MODE_USB)) +		return 0; + +	/* LCPLL check */ +	ret = regmap_read_poll_timeout(udphy->pma_regmap, +				       CMN_ANA_LCPLL_DONE_OFFSET, +				       val, (val & CMN_ANA_LCPLL_AFC_DONE) && +				       (val & CMN_ANA_LCPLL_LOCK_DONE), +				       200, 100); +	if (ret) { +		dev_err(udphy->dev, "cmn ana lcpll lock timeout\n"); +		return ret; +	} + +	if (!udphy->flip) { +		ret = regmap_read_poll_timeout(udphy->pma_regmap, +					       TRSV_LN0_MON_RX_CDR_DONE_OFFSET, +					       val, +					       val & TRSV_LN0_MON_RX_CDR_LOCK_DONE, +					       200, 100); +		if (ret) +			dev_err(udphy->dev, "trsv ln0 mon rx cdr lock timeout\n"); +	} else { +		ret = regmap_read_poll_timeout(udphy->pma_regmap, +					       TRSV_LN2_MON_RX_CDR_DONE_OFFSET, +					       val, +					       val & TRSV_LN2_MON_RX_CDR_LOCK_DONE, +					       200, 100); +		if (ret) +			dev_err(udphy->dev, "trsv ln2 mon rx cdr lock timeout\n"); +	} + +	return 0; +} + +static int rk3588_udphy_init(struct rockchip_udphy *udphy) +{ +	const struct rockchip_udphy_cfg *cfg = udphy->cfgs; +	int ret; + +	/* enable rx lfps for usb */ +	if (udphy->mode & UDPHY_MODE_USB) +		grfreg_write(udphy->udphygrf, &cfg->grfcfg.rx_lfps, true); + +	/* Step 1: power on pma and deassert apb rstn */ +	grfreg_write(udphy->udphygrf, &cfg->grfcfg.low_pwrn, true); + +	udphy_reset_deassert(udphy, "pma_apb"); +	udphy_reset_deassert(udphy, "pcs_apb"); + +	/* Step 2: set init sequence and phy refclk */ +	ret = __regmap_multi_reg_write(udphy->pma_regmap, +				       rk3588_udphy_init_sequence, +				       ARRAY_SIZE(rk3588_udphy_init_sequence)); +	if (ret) { +		dev_err(udphy->dev, "init sequence set error %d\n", ret); +		goto assert_apb; +	} + +	ret = rk3588_udphy_refclk_set(udphy); +	if (ret) { +		dev_err(udphy->dev, "refclk set error %d\n", ret); +		goto assert_apb; +	} + +	/* Step 3: configure lane mux */ +	regmap_update_bits(udphy->pma_regmap, CMN_LANE_MUX_AND_EN_OFFSET, +			   CMN_DP_LANE_MUX_ALL | CMN_DP_LANE_EN_ALL, +			   FIELD_PREP(CMN_DP_LANE_MUX_N(3), +				      udphy->lane_mux_sel[3]) | +			   FIELD_PREP(CMN_DP_LANE_MUX_N(2), +				      udphy->lane_mux_sel[2]) | +			   FIELD_PREP(CMN_DP_LANE_MUX_N(1), +				      udphy->lane_mux_sel[1]) | +			   FIELD_PREP(CMN_DP_LANE_MUX_N(0), +				      udphy->lane_mux_sel[0]) | +			   FIELD_PREP(CMN_DP_LANE_EN_ALL, 0)); + +	/* Step 4: deassert init rstn and wait for 200ns from datasheet */ +	if (udphy->mode & UDPHY_MODE_USB) +		udphy_reset_deassert(udphy, "init"); + +	if (udphy->mode & UDPHY_MODE_DP) { +		regmap_update_bits(udphy->pma_regmap, CMN_DP_RSTN_OFFSET, +				   CMN_DP_INIT_RSTN, +				   FIELD_PREP(CMN_DP_INIT_RSTN, 0x1)); +	} + +	udelay(1); + +	/*  Step 5: deassert cmn/lane rstn */ +	if (udphy->mode & UDPHY_MODE_USB) { +		udphy_reset_deassert(udphy, "cmn"); +		udphy_reset_deassert(udphy, "lane"); +	} + +	/*  Step 6: wait for lock done of pll */ +	ret = rk3588_udphy_status_check(udphy); +	if (ret) +		goto assert_phy; + +	return 0; + +assert_phy: +	udphy_reset_assert(udphy, "init"); +	udphy_reset_assert(udphy, "cmn"); +	udphy_reset_assert(udphy, "lane"); + +assert_apb: +	udphy_reset_assert(udphy, "pma_apb"); +	udphy_reset_assert(udphy, "pcs_apb"); + +	return ret; +} + +static const char * const rk3588_udphy_rst_l[] = { +	"init", "cmn", "lane", "pcs_apb", "pma_apb" +}; + +static const struct rockchip_udphy_cfg rk3588_udphy_cfgs = { +	.num_rsts = ARRAY_SIZE(rk3588_udphy_rst_l), +	.rst_list = rk3588_udphy_rst_l, +	.grfcfg	= { +		/* u2phy-grf */ +		.bvalid_phy_con		= { 0x0008, 1, 0, 0x2, 0x3 }, +		.bvalid_grf_con		= { 0x0010, 3, 2, 0x2, 0x3 }, + +		/* usb-grf */ +		.usb3otg0_cfg		= { 0x001c, 15, 0, 0x1100, 0x0188 }, +		.usb3otg1_cfg		= { 0x0034, 15, 0, 0x1100, 0x0188 }, + +		/* usbdpphy-grf */ +		.low_pwrn		= { 0x0004, 13, 13, 0, 1 }, +		.rx_lfps		= { 0x0004, 14, 14, 0, 1 }, +	}, +	.combophy_init = rk3588_udphy_init, +}; + +static const struct udevice_id rockchip_udphy_dt_match[] = { +	{ +		.compatible = "rockchip,rk3588-usbdp-phy", +		.data = (ulong)&rk3588_udphy_cfgs +	}, +	{ /* sentinel */ } +}; + +U_BOOT_DRIVER(rockchip_udphy_u3_port) = { +	.name		= "rockchip_udphy_u3_port", +	.id		= UCLASS_PHY, +	.ops		= &rockchip_u3phy_ops, +}; + +U_BOOT_DRIVER(rockchip_udphy) = { +	.name		= "rockchip_udphy", +	.id		= UCLASS_PHY, +	.of_match	= rockchip_udphy_dt_match, +	.probe		= rockchip_udphy_probe, +	.bind		= rockchip_udphy_bind, +	.priv_auto	= sizeof(struct rockchip_udphy), +}; diff --git a/drivers/power/regulator/fixed.c b/drivers/power/regulator/fixed.c index ad3b4b98d66..f7ddba8b45e 100644 --- a/drivers/power/regulator/fixed.c +++ b/drivers/power/regulator/fixed.c @@ -25,6 +25,7 @@ static int fixed_regulator_of_to_plat(struct udevice *dev)  {  	struct dm_regulator_uclass_plat *uc_pdata;  	struct regulator_common_plat *plat; +	bool gpios;  	plat = dev_get_plat(dev);  	uc_pdata = dev_get_uclass_plat(dev); @@ -33,7 +34,8 @@ static int fixed_regulator_of_to_plat(struct udevice *dev)  	uc_pdata->type = REGULATOR_TYPE_FIXED; -	return regulator_common_of_to_plat(dev, plat, "gpio"); +	gpios = dev_read_bool(dev, "gpios"); +	return regulator_common_of_to_plat(dev, plat, gpios ? "gpios" : "gpio");  }  static int fixed_regulator_get_value(struct udevice *dev) diff --git a/drivers/video/rockchip/dw_mipi_dsi_rockchip.c b/drivers/video/rockchip/dw_mipi_dsi_rockchip.c index 117c3db21ac..0852b53ebed 100644 --- a/drivers/video/rockchip/dw_mipi_dsi_rockchip.c +++ b/drivers/video/rockchip/dw_mipi_dsi_rockchip.c @@ -134,6 +134,32 @@  #define HS_RX_CONTROL_OF_LANE_2				0x84  #define HS_RX_CONTROL_OF_LANE_3				0x94 +#define DW_MIPI_NEEDS_PHY_CFG_CLK	BIT(0) +#define DW_MIPI_NEEDS_GRF_CLK		BIT(1) + +#define RK3399_GRF_SOC_CON20		0x6250 +#define RK3399_DSI0_LCDC_SEL		BIT(0) +#define RK3399_DSI1_LCDC_SEL		BIT(4) + +#define RK3399_GRF_SOC_CON22		0x6258 +#define RK3399_DSI0_TURNREQUEST		(0xf << 12) +#define RK3399_DSI0_TURNDISABLE		(0xf << 8) +#define RK3399_DSI0_FORCETXSTOPMODE	(0xf << 4) +#define RK3399_DSI0_FORCERXMODE		(0xf << 0) + +#define RK3399_GRF_SOC_CON23		0x625c +#define RK3399_DSI1_TURNDISABLE		(0xf << 12) +#define RK3399_DSI1_FORCETXSTOPMODE	(0xf << 8) +#define RK3399_DSI1_FORCERXMODE		(0xf << 4) +#define RK3399_DSI1_ENABLE		(0xf << 0) + +#define RK3399_GRF_SOC_CON24		0x6260 +#define RK3399_TXRX_MASTERSLAVEZ	BIT(7) +#define RK3399_TXRX_ENABLECLK		BIT(6) +#define RK3399_TXRX_BASEDIR		BIT(5) +#define RK3399_TXRX_SRC_SEL_ISP0	BIT(4) +#define RK3399_TXRX_TURNREQUEST		GENMASK(3, 0) +  #define RK3568_GRF_VO_CON2		0x0368  #define RK3568_DSI0_SKEWCALHS		(0x1f << 11)  #define RK3568_DSI0_FORCETXSTOPMODE	(0xf << 4) @@ -209,6 +235,8 @@ struct dw_rockchip_dsi_priv {  	struct clk *pclk;  	struct clk *ref; +	struct clk *grf_clk; +	struct clk *phy_cfg_clk;  	struct reset_ctl *rst;  	unsigned int lane_mbps; /* per lane */  	u16 input_div; @@ -844,6 +872,28 @@ static int dw_mipi_dsi_rockchip_probe(struct udevice *dev)  		}  	} +	if (cdata->flags & DW_MIPI_NEEDS_PHY_CFG_CLK) { +		priv->phy_cfg_clk = devm_clk_get(dev, "phy_cfg"); +		if (IS_ERR(priv->phy_cfg_clk)) { +			ret = PTR_ERR(priv->phy_cfg_clk); +			dev_err(dev, "phy_cfg_clk clock get error %d\n", ret); +			return ret; +		} + +		clk_enable(priv->phy_cfg_clk); +	} + +	if (cdata->flags & DW_MIPI_NEEDS_GRF_CLK) { +		priv->grf_clk = devm_clk_get(dev, "grf"); +		if (IS_ERR(priv->grf_clk)) { +			ret = PTR_ERR(priv->grf_clk); +			dev_err(dev, "grf_clk clock get error %d\n", ret); +			return ret; +		} + +		clk_enable(priv->grf_clk); +	} +  	priv->rst = devm_reset_control_get_by_index(device->dev, 0);  	if (IS_ERR(priv->rst)) {  		ret = PTR_ERR(priv->rst); @@ -864,6 +914,52 @@ struct video_bridge_ops dw_mipi_dsi_rockchip_ops = {  	.set_backlight = dw_mipi_dsi_rockchip_set_bl,  }; +static const struct rockchip_dw_dsi_chip_data rk3399_chip_data[] = { +	{ +		.reg = 0xff960000, +		.lcdsel_grf_reg = RK3399_GRF_SOC_CON20, +		.lcdsel_big = HIWORD_UPDATE(0, RK3399_DSI0_LCDC_SEL), +		.lcdsel_lit = HIWORD_UPDATE(RK3399_DSI0_LCDC_SEL, +					    RK3399_DSI0_LCDC_SEL), + +		.lanecfg1_grf_reg = RK3399_GRF_SOC_CON22, +		.lanecfg1 = HIWORD_UPDATE(0, RK3399_DSI0_TURNREQUEST | +					     RK3399_DSI0_TURNDISABLE | +					     RK3399_DSI0_FORCETXSTOPMODE | +					     RK3399_DSI0_FORCERXMODE), + +		.flags = DW_MIPI_NEEDS_PHY_CFG_CLK | DW_MIPI_NEEDS_GRF_CLK, +		.max_data_lanes = 4, +	}, +	{ +		.reg = 0xff968000, +		.lcdsel_grf_reg = RK3399_GRF_SOC_CON20, +		.lcdsel_big = HIWORD_UPDATE(0, RK3399_DSI1_LCDC_SEL), +		.lcdsel_lit = HIWORD_UPDATE(RK3399_DSI1_LCDC_SEL, +					    RK3399_DSI1_LCDC_SEL), + +		.lanecfg1_grf_reg = RK3399_GRF_SOC_CON23, +		.lanecfg1 = HIWORD_UPDATE(0, RK3399_DSI1_TURNDISABLE | +					     RK3399_DSI1_FORCETXSTOPMODE | +					     RK3399_DSI1_FORCERXMODE | +					     RK3399_DSI1_ENABLE), + +		.lanecfg2_grf_reg = RK3399_GRF_SOC_CON24, +		.lanecfg2 = HIWORD_UPDATE(RK3399_TXRX_MASTERSLAVEZ | +					  RK3399_TXRX_ENABLECLK, +					  RK3399_TXRX_MASTERSLAVEZ | +					  RK3399_TXRX_ENABLECLK | +					  RK3399_TXRX_BASEDIR), + +		.enable_grf_reg = RK3399_GRF_SOC_CON23, +		.enable = HIWORD_UPDATE(RK3399_DSI1_ENABLE, RK3399_DSI1_ENABLE), + +		.flags = DW_MIPI_NEEDS_PHY_CFG_CLK | DW_MIPI_NEEDS_GRF_CLK, +		.max_data_lanes = 4, +	}, +	{ /* sentinel */ } +}; +  static const struct rockchip_dw_dsi_chip_data rk3568_chip_data[] = {  	{  		.reg = 0xfe060000, @@ -887,6 +983,9 @@ static const struct rockchip_dw_dsi_chip_data rk3568_chip_data[] = {  };  static const struct udevice_id dw_mipi_dsi_rockchip_dt_ids[] = { +	{ .compatible = "rockchip,rk3399-mipi-dsi", +	  .data = (long)&rk3399_chip_data, +	},  	{ .compatible = "rockchip,rk3568-mipi-dsi",  	  .data = (long)&rk3568_chip_data,  	}, | 
